Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for cortex-m-rt 0.7.5 #533

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prepare for cortex-m-rt 0.7.5 #533

wants to merge 1 commit into from

Conversation

adamgreig
Copy link
Member

Fixes #532.

@adamgreig adamgreig requested a review from a team as a code owner May 19, 2024 23:20
@thejpster
Copy link
Contributor

Before we do the releases, have we checked that the new macro works as expected and rejects mismatched hard fault signatures?

@diondokter
Copy link
Contributor

Before we do the releases, have we checked that the new macro works as expected and rejects mismatched hard fault signatures?

Tests were added: https://github.com/rust-embedded/cortex-m/blob/master/cortex-m-rt/tests/compile-fail/hard-fault-bad-signature-3.rs
There are more too.

It doesn't pick up on unreleased macro crate releases because it defines the dependency with a path:

[dependencies]
cortex-m-rt-macros = { path = "macros", version = "=0.7.0" }

This is probably the correct way in this crate, but yeah it does make it easy to forget to release any new version of it.

@jonathanpallant
Copy link
Contributor

I think one solution for this is for the main branch to be changed to have the version number N + 1 right after version N is released, and for any dependencies within the same repo to also use N + 1 as a version number.

@jamesmunns
Copy link
Member

CC #535 - @jannic thinks it is important before we release

@jamesmunns
Copy link
Member

Also noting that @newAM successfully yanked v0.7.4 - we should probably note this in the release docs that we are fixing those regression(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HardFault handler is completely broken in c-m-rt 0.7.4
5 participants