Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to LLVM libcalls-sync on custom targets page #76

Merged
merged 1 commit into from Feb 14, 2022
Merged

Fix link to LLVM libcalls-sync on custom targets page #76

merged 1 commit into from Feb 14, 2022

Conversation

calvinkosmatka
Copy link
Contributor

Found a typo'd link on the custom targets page

@calvinkosmatka calvinkosmatka requested a review from a team as a code owner February 10, 2022 03:32
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jamesmunns (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Feb 10, 2022
jamesmunns
jamesmunns approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

bors r+

bors bot added a commit that referenced this pull request Feb 10, 2022
@bors @calvinkosmatka
Merge #76
b99dd0e 
76: Fix link to LLVM libcalls-sync on custom targets page r=jamesmunns a=calvinkosmatka

Found a typo'd link on the custom targets page

Co-authored-by: Calvin Kosmatka <calvin.kosmatka@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 10, 2022

Build failed:

@eldruin eldruin mentioned this pull request Feb 10, 2022
Closed
@adamgreig
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented Feb 14, 2022

Build succeeded:

@bors bors bot merged commit 6c669e2 into rust-embedded:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmunns jamesmunns jamesmunns approved these changes

Assignees

@jamesmunns jamesmunns

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@calvinkosmatka @rust-highfive @adamgreig @jamesmunns