Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Add Serial implementation #8

Closed
rnestler opened this issue Jun 8, 2018 · 3 comments
Closed

Feature request: Add Serial implementation #8

rnestler opened this issue Jun 8, 2018 · 3 comments

Comments

@rnestler
Copy link
Contributor

rnestler commented Jun 8, 2018

As far as I can tell there isn't yet a serial implementation here, is it?
I think one could probably implement it with the help of the serial crate.
@RandomInsano
Copy link

RandomInsano commented Jun 9, 2018 via email

@rnestler rnestler mentioned this issue Jun 9, 2018
Merged
@rnestler
Copy link
Contributor Author

I noticed that there exists https://github.com/thenewwazoo/serial-embedded-hal already, which implements the embedded-hal serial trait with the serial crate.

bors bot added a commit that referenced this issue Jun 16, 2019
@bors @rnestler @dbrgn
Merge #9
235d9db 
9: Add serial::Read/Write implementation r=ryankurte a=rnestler

So this is just a quick PoC to implement #8.
@japaric Do you think it would be OK to implement it in that way? If yes I can finish it up.

Co-authored-by: Raphael Nestler <raphael.nestler@gmail.com>
Co-authored-by: Raphael Nestler <raphael.nestler@sensirion.com>
Co-authored-by: Danilo Bargen <mail@dbrgn.ch>
@rnestler
Copy link
Contributor Author

This is resolved with #9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RandomInsano @rnestler