Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of embedded_hal::digital::IoPin #60

Merged
merged 3 commits into from
Oct 4, 2021

Conversation

MorganR
Copy link
Contributor

@MorganR MorganR commented Apr 25, 2021

This is just a draft, and is pending the PR merge of an IoPin implementation into embedded_hal.

I've verified it with a no-std DHT11 driver based on the IoPin PR.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Cargo.toml Outdated Show resolved Hide resolved
@MorganR
Copy link
Contributor Author

MorganR commented Apr 27, 2021

This has been updated to match the definition of IoPin as merged in embedded_hal PR 269.

@MorganR
Copy link
Contributor Author

MorganR commented May 16, 2021

Hey folks, I've added a commit to remove the try_ prefixes so this can build against the embedded-hal HEAD. Would you rather merge it like this, or wait until embedded-hal pushes the next alpha release?

@eldruin
Copy link
Member

eldruin commented May 17, 2021

Thanks! It would be better only to depend on released versions of embedded-hal.

@eldruin
Copy link
Member

eldruin commented Sep 28, 2021

@MorganR Could you update this PR now that I updated this repository to embedded-hal 1.0.0-alpha.5?

@MorganR
Copy link
Contributor Author

MorganR commented Oct 2, 2021

Absolutely, I'll update it by the end of the weekend

@MorganR MorganR marked this pull request as ready for review October 2, 2021 17:25
@MorganR MorganR requested a review from a team as a code owner October 2, 2021 17:25
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!
bors r+

@bors
Copy link
Contributor

bors bot commented Oct 4, 2021

@bors bors bot merged commit 92960cc into rust-embedded:master Oct 4, 2021
@eldruin
Copy link
Member

eldruin commented Oct 7, 2021

@MorganR FYI this is published as part of the 0.4.0-alpha.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Review is incomplete T-embedded-linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants