Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embedded-hal to 1.0.0-alpha.8 #83

Merged
merged 1 commit into from Aug 4, 2022

Conversation

kelnos
Copy link
Contributor

@kelnos kelnos commented May 29, 2022

No description provided.

@kelnos kelnos requested a review from a team as a code owner May 29, 2022 22:51
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Review is incomplete T-embedded-linux labels May 29, 2022
@kelnos
Copy link
Contributor Author

kelnos commented Jun 6, 2022

Looks like embedded-hal 1.0.0-alpha.8 uses include_str!() for doc inclusion, which doesn't appear to be available in rust 1.46.0. I'm fine changing the MSRV; what would you suggest is a good target for it?

@har7an
Copy link

har7an commented Aug 2, 2022

Hello,

is there any progress on this?

@eldruin
Copy link
Member

eldruin commented Aug 2, 2022

Thanks for the reminder.
Updating the MSRV to version 1.54.0 would make sense, since that is the version that embedded-hal 1.0 will have (at this time, may increase further).

@kelnos kelnos force-pushed the embedded-hal-1.0.0-alpha.8 branch from ee5b7da to 21dbc04 Compare August 2, 2022 19:40
@kelnos
Copy link
Contributor Author

kelnos commented Aug 2, 2022

Ok, 1.54.0 it is!

@eldruin
Copy link
Member

eldruin commented Aug 2, 2022

Thanks!
Could you also update the MSRV in the bors.toml file? otherwise this will not merge

@kelnos kelnos force-pushed the embedded-hal-1.0.0-alpha.8 branch from 21dbc04 to 63f559d Compare August 2, 2022 20:05
@kelnos
Copy link
Contributor Author

kelnos commented Aug 2, 2022

Could you also update the MSRV in the bors.toml file? otherwise this will not merge

Done!

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, this looks good to me, although the transfer_in_place is actually fake since it copies the buffer.
We could also add the small piece of unsafe code we had back some day if this is a problem for somebody, though.
Could you also add an entry to the changelog?

This also bumps the MSRV to 1.54.0, as this is embedded-hal's current
requirement.
@kelnos kelnos force-pushed the embedded-hal-1.0.0-alpha.8 branch from 63f559d to 19749d5 Compare August 3, 2022 12:22
@kelnos
Copy link
Contributor Author

kelnos commented Aug 3, 2022

Could you also add an entry to the changelog?

Done

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
bors r+

@bors
Copy link
Contributor

bors bot commented Aug 4, 2022

@bors bors bot merged commit 66e773b into rust-embedded:master Aug 4, 2022
bors bot added a commit that referenced this pull request Aug 4, 2022
84: Prepare 0.4.0-alpha.3 release r=ryankurte a=eldruin

Now that #83 is in, it would be good to publish a new alpha release.

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Review is incomplete T-embedded-linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants