Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix critial section implementation #121

Merged
merged 1 commit into from
Jan 18, 2023
Merged

fix critial section implementation #121

merged 1 commit into from
Jan 18, 2023

Conversation

tfx2001
Copy link
Contributor

@tfx2001 tfx2001 commented Jan 17, 2023 •
edited

It should be 0b1000 rather than 0b100. Bit 2 is a reserved bit, and Bit 3 is MIE that needs to be cleared.

image

@tfx2001 tfx2001 requested a review from a team as a code owner January 17, 2023 09:11
dkhayes117
dkhayes117 previously approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@dkhayes117 dkhayes117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes! Thanks for bringing this up.

almindor
almindor previously approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@almindor almindor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find and fix thanks! Could you please add CHANGELOG entry?

@tfx2001 tfx2001 dismissed stale reviews from almindor and dkhayes117 via 5dafe25 January 18, 2023 03:22
@tfx2001
Copy link
Contributor Author

tfx2001 commented Jan 18, 2023

Nice find and fix thanks! Could you please add CHANGELOG entry?

Done.

dkhayes117
dkhayes117 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@dkhayes117 dkhayes117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@dkhayes117
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 18, 2023

Build succeeded:

@bors bors bot merged commit bdf59cc into rust-embedded:master Jan 18, 2023
@almindor almindor mentioned this pull request Jan 18, 2023
Merged
bors bot added a commit that referenced this pull request Jan 18, 2023
@bors @almindor
Merge #122
620c5bf 
122: release v0.10.1 with critical section bug r=dkhayes117 a=almindor

Release the critical section bugfix from #121 

Co-authored-by: Ales Katona <ales@katona.me>
@tfx2001 tfx2001 deleted the patch-1 branch January 20, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhayes117 dkhayes117 dkhayes117 approved these changes

@almindor almindor almindor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tfx2001 @dkhayes117 @almindor