Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change baud 576000 to 460800 #96

Closed
wants to merge 3 commits into from
Closed

Change baud 576000 to 460800 #96

wants to merge 3 commits into from

Conversation

sachaos
Copy link
Contributor

@sachaos sachaos commented Jan 3, 2021

Fix #95

macOS is not supporting baud 576000.
To fix this problem use 460800 as baud.

@sachaos
Replace baud 576000 to 460800
d3853c2 
git grep -l '576000' | xargs sed -i '' -e 's/576000/460800/g'
git grep -l '576_000' | xargs sed -i '' -e 's/576_000/460_800/g'
@sachaos
Change IBRD & FBRD
a3721e4
@sachaos sachaos mentioned this pull request Jan 3, 2021
Closed
@andre-richter
Copy link
Member

andre-richter commented Jan 3, 2021 •
edited

Thanks a lot 🙏, I will review later today.

But you still need the stty command, right?

@sachaos
Copy link
Contributor Author

sachaos commented Jan 3, 2021

@andre-richter

But you still need the stty command, right?

No. There is no need to run stty command.
I confirmed SerialPort.new accepted 460800 correctly.

@andre-richter
Copy link
Member

@andre-richter

But you still need the stty command, right?

No. There is no need to run stty command.
I confirmed SerialPort.new accepted 460800 correctly.

Even better!
The reason I bumped it recently is that upcoming tutorials might increase the kernel size quite a bit, so this is done in preparation to keep chainloading duration down.

Once I find time to review this, I might check if 921600 baud can also work on both macOS and Linux.

@andre-richter
Copy link
Member

Hi @sachaos,

I am still in the process of testing 921600 baud. So far, it looks good on both Linux PC and Mac. Please bear with me until I am done. Thanks 👍

@sachaos
Copy link
Contributor Author

sachaos commented Jan 4, 2021

This PR is no longer needed.
Ref: #97

@sachaos sachaos closed this Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected Error: #<Errno::EINVAL: Invalid argument - tcsetattr>
2 participants
@sachaos @andre-richter