Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode dimIndex ranges #195

Merged
merged 1 commit into from Feb 12, 2022
Merged

encode dimIndex ranges #195

merged 1 commit into from Feb 12, 2022

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Feb 12, 2022

@burrbull
Copy link
Member Author

cc @Emilgardis

@bors
Copy link
Contributor

bors bot commented Feb 12, 2022

✌️ burrbull can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

adamgreig
adamgreig previously approved these changes Feb 12, 2022
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe worth fixing the clippy lint about the return Some(min..=max);?

I also think the max.wrapping_sub(min) could just be (max - min) since it can't ever underflow, but it doesn't really matter here.

bors d+

@burrbull
Copy link
Member Author

Fixed.
bors r+

@bors
Copy link
Contributor

bors bot commented Feb 12, 2022

👎 Rejected by too few approved reviews

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah, what use is bors delegating if as soon as you push a commit it revokes approval?

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 12, 2022

Build succeeded:

@bors bors bot merged commit 2cc1ad5 into master Feb 12, 2022
@bors bors bot deleted the dimIndex-encode branch February 12, 2022 17:24
@therealprof
Copy link
Contributor

hah, what use is bors delegating if as soon as you push a commit it revokes approval?

bors r+

Yeah, need to change the configuration to not dismiss a review after a new commit.

@Emilgardis
Copy link
Member

hah, what use is bors delegating if as soon as you push a commit it revokes approval?
bors r+

Yeah, need to change the configuration to not dismiss a review after a new commit.

it's quite easy to change branch protection rules, should we?

image

@therealprof
Copy link
Contributor

I'm all for it, especially for projects with little risk of abuse (like sneaking in changes after approval of unmergeable PRs). However we'd have to be more permissive in our rules: https://github.com/rust-embedded/wg/blob/master/ops/post-transfer.md#repository-settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants