-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peripherals as scoped singletons #158
Conversation
Regarding names, how about |
I'm going ahead with
I'm going to defer this until right before the actual release @homunkulus r+ |
📌 Commit e114878 has been approved by |
Peripherals as scoped singletons See this RFC for details: #157 With this change device crates will need to depend on a version of the cortex-m crate that includes rust-embedded/cortex-m#65 ### TODO - [x] accept the RFC - [ ] Check that non cortex-m targets still work - [x] decide on better names for `Peripherals::{all,_all}`
@homunkulus r+ |
📌 Commit 56cd979 has been approved by |
Peripherals as scoped singletons See this RFC for details: #157 With this change device crates will need to depend on a version of the cortex-m crate that includes rust-embedded/cortex-m#65 ### TODO - [x] accept the RFC - [ ] Check that non cortex-m targets still work - [x] decide on better names for `Peripherals::{all,_all}`
💔 Test failed - status-travis |
@homunkulus r+ |
📌 Commit 9c2ec7b has been approved by |
Peripherals as scoped singletons See this RFC for details: #157 With this change device crates will need to depend on a version of the cortex-m crate that includes rust-embedded/cortex-m#65 ### TODO - [x] accept the RFC - [ ] Check that non cortex-m targets still work - [x] decide on better names for `Peripherals::{all,_all}`
Peripherals as scoped singletons See this RFC for details: rust-embedded/svd2rust#157 - The first commit adapts this crate to the changes in rust-embedded/cortex-m#65 and rust-embedded/svd2rust#158 - ~~The second commit is an alternative implementation of RFC #47 (there's another implementation in #49. This second commit is not required for RFC157 but let us experiment with safe DMA abstractions.~~ postponed ### TODO - [x] un-bless peripherals as resources. Peripherals as resources were special cased: if resource listed in e.g. `app.tasks.FOO.resources` didn't appear in `app.resources` then it was assumed to be a peripheral and special code was generated for it. This is no longer required under RFC157. ~~This depends on PR rtic-rs/rtic-syntax#2~~ postponed
@homunkulus r+ |
📌 Commit 3b27815 has been approved by |
Peripherals as scoped singletons See this RFC for details: #157 With this change device crates will need to depend on a version of the cortex-m crate that includes rust-embedded/cortex-m#65 ### TODO - [x] accept the RFC - [ ] Check that non cortex-m targets still work - [x] decide on better names for `Peripherals::{all,_all}`
☀️ Test successful - status-appveyor, status-travis |
I like those! Short and to the point! |
See this RFC for details: #157
With this change device crates will need to depend on a version of the cortex-m crate that includes rust-embedded/cortex-m#65
TODO
Check that non cortex-m targets still workpostponedPeripherals::{all,_all}