-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address build failures on nightly due to lint #244
Merged
japaric
merged 2 commits into
rust-embedded:master
from
therealprof:features/fix-nightly-build
Oct 30, 2018
Merged
Address build failures on nightly due to lint #244
japaric
merged 2 commits into
rust-embedded:master
from
therealprof:features/fix-nightly-build
Oct 30, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
bors try |
tryBuild failed |
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
bors try |
tryBuild failed |
After a lot of massaging due to additional problems retrieving the docker containers those two changes will bring r? @rust-embedded/tools |
jamesmunns
approved these changes
Oct 30, 2018
bors r+ |
bors retry |
Travis build was green. Merging manually. |
Timed out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Egger daniel@eggers-club.de