Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow building on 1.31 (stable) #267

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Allow building on 1.31 (stable) #267

merged 1 commit into from
Dec 18, 2018

Conversation

tones111
Copy link
Contributor

@tones111 tones111 commented Dec 9, 2018

This change fixes #245

@tones111 tones111 requested a review from a team as a code owner December 9, 2018 15:06
@Emilgardis
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Dec 10, 2018
@bors
Try #267:
af3b153
@bors
Copy link
Contributor

bors bot commented Dec 10, 2018

try

Build failed

@therealprof
Copy link
Contributor

bors retry

bors bot added a commit that referenced this pull request Dec 10, 2018
@bors
Try #267:
f4870f7
@bors
Copy link
Contributor

bors bot commented Dec 10, 2018

try

Build failed

1 similar comment
@bors
Copy link
Contributor

bors bot commented Dec 10, 2018

try

Build failed

therealprof
therealprof approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@therealprof therealprof merged commit ec6f461 into rust-embedded:master Dec 18, 2018
@tones111 tones111 deleted the lints branch January 27, 2019 17:00
@tones111 tones111 mentioned this pull request Jan 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove nightly compatibility workarounds when 1.31 is stable
3 participants
@tones111 @Emilgardis @therealprof