Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to modify clusters #27

Merged
merged 1 commit into from
May 3, 2020
Merged

Add the ability to modify clusters #27

merged 1 commit into from
May 3, 2020

Conversation

jessebraham
Copy link
Member

In a vendor-supplied SVD file, the following layout was encountered within a peripheral:

<registers>
  <register>...</register>
  <register>...</register>
  <cluster>
    <name>CHANNEL[%s]</name>
    <description />
    <register>...</register>
    <register>...</register>
  </cluster>
</registers>

The ability to modify the <cluster> tag's description attribute was needed, however this did not appear to be possible. This PR is just a quick and dirty method of accomplishing such. Patching can be performed by:

DMAC:
  _modify:
    _cluster:
      "CHANNEL*":
        description: "Direct Memory Access Channels"

I've sort of repurposed _cluster here, but this shouldn't cause any problems (as far as I can tell) as it's being used in a new context. If there are any concerns with this approach, or any other changes need to be made, please just let me know and I'll be happy to do so.

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented May 3, 2020

Build succeeded:

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 96b135c into rust-embedded:master May 3, 2020
@jessebraham jessebraham deleted the modify-cluster branch May 3, 2020 16:58
@hegza hegza mentioned this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants