-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC for moving cross to its own organisation #590
Conversation
While not opposed to it, I don't see how moving to another org solves the problem of having too few maintainers. Were any volunteers from cross-rs/cross#574 added to the tools team yet? That seems like the simplest solution to me. |
They weren't, mainly because it didn't seem fair to have people interested in helping with And I guess on top of that it's still the case that |
rfcs/0590-new-cross-org.md
Outdated
existing Tools team will be added as owners to the new organisation, which is | ||
otherwise a separate entity from the working group. In addition, some | ||
volunteers from the call-for-help issue could be added as maintainers and | ||
eventually organisation owners. A new GitHub team will be created and granted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some volunteers [...] could be added [...] and eventually
what does this mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it's quite vaguely worded because I don't know exactly how we'd want this to look. I expect we'd initially add some volunteers from that call-for-help thread (after chatting to them of course) who could review and merge PRs, and possibly also publish to crates.io, and then over time expect to grant org ownership too once it's had more time to settle down.
rfcs/0590-new-cross-org.md
Outdated
advance of writing this RFC to ensure name availability). Volunteers from the | ||
existing Tools team will be added as owners to the new organisation, which is | ||
otherwise a separate entity from the working group. In addition, some | ||
volunteers from the call-for-help issue could be added as maintainers and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What role is a maintainer
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean people with access to merge PRs into the repo, and perform other maintenance tasks like labelling and closing issues etc. Perhaps it should also include publishing.
# Detailed design | ||
[design]: #detailed-design | ||
|
||
We transfer the `cross` repository to a new `cross-rs` organisation (created in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any work needed to be done before transferring?
I can imagine cutting out some mentions of the Tools Team/EWG in various parts.
Should authors in cargo manifest still mentions EWG? Or can the full field be dropped? (the field is optional in newer rust)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should update the README to indicate that while the project used to be maintained by the WG, it no longer is. I don't mind about the authors
field, perhaps simplest to remove it.
@Emilgardis any further thoughts on the comments above? Would you like me to expand on them in the RFC text? |
The open discussions I'd want to have resolved, otherwise I have no further comments so far :) |
@rust-embedded/tools I've updated the PR text to clarify:
|
So this is up for a vote of the @rust-embedded/tools team now. Please tick your box: |
@reitermarkus, any further thoughts on this? |
Are we quorate? |
No further thoughts from me. |
OK, thanks for the input, everyone. I'll go ahead and merge this and then transfer bors merge |
Build succeeded: |
@rust-embedded/tools; I've invited each of you to be an owner in the new organisation as per this PR; there's no obligation to accept or be involved with cross, so please feel free to accept or decline the invitation as you wish :) |
Rendered.
This RFC is for the attention of @rust-embedded/tools who currently maintain the
cross
crate.cc cross-rs/cross#574