Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC for moving cross to its own organisation #590

Merged
merged 3 commits into from
Jan 23, 2022
Merged

RFC for moving cross to its own organisation #590

merged 3 commits into from
Jan 23, 2022

Conversation

adamgreig
Copy link
Member

Rendered.

This RFC is for the attention of @rust-embedded/tools who currently maintain the cross crate.

cc cross-rs/cross#574

burrbull
burrbull previously approved these changes Dec 7, 2021
therealprof
therealprof previously approved these changes Dec 7, 2021
@adamgreig adamgreig dismissed stale reviews from therealprof and burrbull via 32c479d December 7, 2021 19:18
burrbull
burrbull previously approved these changes Dec 7, 2021
thejpster
thejpster previously approved these changes Dec 7, 2021
@reitermarkus
Copy link
Member

While not opposed to it, I don't see how moving to another org solves the problem of having too few maintainers. Were any volunteers from cross-rs/cross#574 added to the tools team yet? That seems like the simplest solution to me.

@adamgreig
Copy link
Member Author

They weren't, mainly because it didn't seem fair to have people interested in helping with cross also get signed up for being wg members and getting requested to review svd2rust changes and the like. The hope would be that in a new organisation it can be very quick and easy to add more maintainers and let them control the direction of the project without going through the tools team and wg processes.

And I guess on top of that it's still the case that cross no longer seems like an obvious fit for the embedded WG, though I'm open to being challenged on that front as I've not really used it in anger for anything.

existing Tools team will be added as owners to the new organisation, which is
otherwise a separate entity from the working group. In addition, some
volunteers from the call-for-help issue could be added as maintainers and
eventually organisation owners. A new GitHub team will be created and granted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some volunteers [...] could be added [...] and eventually

what does this mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it's quite vaguely worded because I don't know exactly how we'd want this to look. I expect we'd initially add some volunteers from that call-for-help thread (after chatting to them of course) who could review and merge PRs, and possibly also publish to crates.io, and then over time expect to grant org ownership too once it's had more time to settle down.

advance of writing this RFC to ensure name availability). Volunteers from the
existing Tools team will be added as owners to the new organisation, which is
otherwise a separate entity from the working group. In addition, some
volunteers from the call-for-help issue could be added as maintainers and
Copy link
Member

@Emilgardis Emilgardis Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What role is a maintainer ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean people with access to merge PRs into the repo, and perform other maintenance tasks like labelling and closing issues etc. Perhaps it should also include publishing.

# Detailed design
[design]: #detailed-design

We transfer the `cross` repository to a new `cross-rs` organisation (created in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any work needed to be done before transferring?

I can imagine cutting out some mentions of the Tools Team/EWG in various parts.

Should authors in cargo manifest still mentions EWG? Or can the full field be dropped? (the field is optional in newer rust)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should update the README to indicate that while the project used to be maintained by the WG, it no longer is. I don't mind about the authors field, perhaps simplest to remove it.

rfcs/0590-new-cross-org.md Show resolved Hide resolved
@adamgreig
Copy link
Member Author

@Emilgardis any further thoughts on the comments above? Would you like me to expand on them in the RFC text?

@Emilgardis
Copy link
Member

Emilgardis commented Dec 23, 2021

The open discussions I'd want to have resolved, otherwise I have no further comments so far :)

ryankurte
ryankurte previously approved these changes Jan 11, 2022
@adamgreig adamgreig dismissed stale reviews from ryankurte, thejpster, and burrbull via 07af85f January 12, 2022 00:44
@adamgreig
Copy link
Member Author

@rust-embedded/tools I've updated the PR text to clarify:

  • We'll move the repository and no longer be responsible for it (the maintainers of the new organisation will instead); the rest of the plan is just our initial intent but isn't binding on the new organisation, which isn't part of the WG
  • Moving will involve updating the README and Cargo.toml
  • New maintainers will have write access to the repository

@therealprof therealprof added needs-decision This RFC or PR needs to be approved by the majority of reviewers before it's merged RFC T-tools labels Jan 12, 2022
@therealprof
Copy link
Contributor

therealprof commented Jan 12, 2022

So this is up for a vote of the @rust-embedded/tools team now.

Please tick your box:

@adamgreig
Copy link
Member Author

@reitermarkus, any further thoughts on this?

@thejpster
Copy link
Contributor

Are we quorate?

@reitermarkus
Copy link
Member

No further thoughts from me.

@adamgreig adamgreig removed the needs-decision This RFC or PR needs to be approved by the majority of reviewers before it's merged label Jan 23, 2022
@adamgreig
Copy link
Member Author

OK, thanks for the input, everyone. I'll go ahead and merge this and then transfer cross over.

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 23, 2022

Build succeeded:

@bors bors bot merged commit e1e9274 into master Jan 23, 2022
@adamgreig adamgreig deleted the cross-rfc branch January 23, 2022 21:27
@adamgreig
Copy link
Member Author

adamgreig commented Jan 23, 2022

@rust-embedded/tools; I've invited each of you to be an owner in the new organisation as per this PR; there's no obligation to accept or be involved with cross, so please feel free to accept or decline the invitation as you wish :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants