Introduce the concept of Etable in core #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
commented
Oct 29, 2023
| @@ -1,4 +1,4 @@ | |||
| [toolchain] | |||
| channel = "1.68.2" | |||
| channel = "nightly" | |||
There was a problem hiding this comment.
Because of rust-lang/rust#116015
We don't need any nightly features.
To switch back to stable once that fix on Rust goes live.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #183
Make an
Etablethat can be customized downstream to add additional handlers. The goal is so that runtime does not need to rely on trapping for common opcodes, which is unnecessary overhead. In the future,Runtimeshould be a really thin wrapper aroundMachine, andMachinewill solely handle the interpreter loop. Only the gasometer will wrap heavily (but we'll utilize chunk gas metering).This also makes
AsyncRuntimeeasier.