Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MacroInvocLexerBase in MacroInvocLexer #2497

Merged
merged 1 commit into from Aug 1, 2023
Merged

Use MacroInvocLexerBase in MacroInvocLexer #2497

merged 1 commit into from Aug 1, 2023

Conversation

powerboat9
Copy link
Contributor

Split from #2337

@powerboat9
Use MacroInvocLexerBase in MacroInvocLexer
50bca65 
gcc/rust/ChangeLog:

	* expand/rust-macro-invoc-lexer.cc
	(MacroInvocLexer::skip_token): Remove.
	* expand/rust-macro-invoc-lexer.h
	(class MacroInvocLexer): Extend MacroInvocLexerBase.

Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
@P-E-P P-E-P added the cleanup label Aug 1, 2023
@P-E-P P-E-P added this to In progress in Project Pineapple via automation Aug 1, 2023
@P-E-P P-E-P added this to the GCC 14 Stage 3 milestone Aug 1, 2023
Project Pineapple automation moved this from In progress to Reviewer approved Aug 1, 2023
CohenArthur
CohenArthur approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

@CohenArthur CohenArthur added this pull request to the merge queue Aug 1, 2023
Merged via the queue into Rust-GCC:master with commit cc167a9 Aug 1, 2023
9 checks passed
Project Pineapple automation moved this from Reviewer approved to Done Aug 1, 2023
@powerboat9 powerboat9 deleted the join-invoc-a branch August 1, 2023 20:12
@powerboat9 powerboat9 mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-E-P P-E-P P-E-P approved these changes

@CohenArthur CohenArthur CohenArthur approved these changes

Assignees
No one assigned
Labels
cleanup
Projects
Project Pineapple
  
Done
Milestone
GCC 14 Stage 3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@powerboat9 @P-E-P @CohenArthur