Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate .merge() #47

Closed
bluss opened this issue Aug 10, 2015 · 1 comment
Closed

Investigate .merge() #47

bluss opened this issue Aug 10, 2015 · 1 comment

Comments

@bluss
Copy link
Member

bluss commented Aug 10, 2015

@frankmcsherry reported a big runtime improvement by switching from .merge(j) to .merge_by(j, Ord::cmp), with merge::wrapper showing up in the profile.

  • .partial_ord() call being harmful?
  • function pointer vs inlined closure issue?

(Profile says: It's both)

@bluss
Copy link
Member Author

bluss commented Aug 10, 2015

Recommending calling mode .merge_by(j, |a, b| if a <= b { Ordering::Less } else { Ordering::Greater }) as it is now (this is the best way for integers)..

This was referenced Aug 11, 2015
@bluss bluss mentioned this issue Aug 24, 2015
@bluss bluss closed this as completed in #53 Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant