Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using function pointers #49

Closed
bluss opened this issue Aug 11, 2015 · 0 comments
Closed

Stop using function pointers #49

bluss opened this issue Aug 11, 2015 · 0 comments
Labels
performance

Comments

@bluss
Copy link
Member

bluss commented Aug 11, 2015

Function pointers are useful in place of closures, because we can actually return them without boxing; however, the virtual calls are hard for the compiler to inline, leading to degradation, see #47.

For itertools 0.4.0, remove function pointers. Possible workarounds: Wrapper types. Unit structs as statically compiled function values.
@bluss bluss mentioned this issue Aug 11, 2015
Closed
9 tasks
bluss added a commit that referenced this issue Aug 23, 2015
@bluss
Update Merge and MergeBy: avoid function pointers
4756957 
Refactor common parts of merge into MergeCore

For issue #49
bluss added a commit that referenced this issue Aug 23, 2015
@bluss
Stop using function pointers for .dedup()
f82e964 
For issue #49
This was referenced Aug 23, 2015
Merged
Closed
bluss added a commit that referenced this issue Sep 4, 2015
@bluss
Update Merge and MergeBy: avoid function pointers
5f56ce5 
Refactor common parts of merge into MergeCore

For issue #49
bluss added a commit that referenced this issue Sep 4, 2015
@bluss
Stop using function pointers for .dedup()
d249c20 
For issue #49
@bluss bluss closed this as completed in #53 Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bluss