Cleanup some clippy lints

[phimuemue]

I cleaned up some things I got from clippy. I only changed what I'd consider straightforward.

I think it would eventually be beneficial to resolve the remaining lints, so that it is easier to identify real problems spotted by clippy. Do we have a policy regarding this?

Off-topic: I would have merged this right away, but I did not want to introduce conflicts with existing PRs. Is there a way to check if my commits would introduce conflicts?

[jswrenn]

I think it would eventually be beneficial to resolve the remaining lints, so that it is easier to identify real problems spotted by clippy. Do we have a policy regarding this?

Go for it!

Off-topic: I would have merged this right away, but I did not want to introduce conflicts with existing PRs. Is there a way to check if my commits would introduce conflicts?

I don't know of any way to quickly judge whether a PR introduces merge conflicts with other PRs. Before merging big PRs, I usually scan through the list of other PRs and see if there's any low-hanging fruit ready to be merged.

I'm currently on my honeymoon and COVID's made my work weird (I do education research), so I'm short on time. If you have the desire and time to knock down the list of pending PRs, feel free to go for it!

[phimuemue]

I'm currently on my honeymoon

Hey, congratulations! Nice to hear this - I hope you're having a great time.

and COVID's made my work weird (I do education research), so I'm short on time.

Wish you all the best for your work.

[jplatte]

Bump.

[phimuemue]

Bump.

@jplatte Have you thoroughly reviewed this? (I'd prefer a second pair of eyes on this, in particular the match bool -> if/else.)

If yes, and if @jswrenn has no objections, I'd merge this.

[jplatte]

Have you thoroughly reviewed this?

I have now :)

The bool matching change looks good; there's one tiny thing I've noticed but I think this can be merged.

[jswrenn]

This looks good to me. Ready to merge, @phimuemue?

[phimuemue]

bors r+

[bors]

Build succeeded:

• continuous-integration/travis-ci/push