Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapInto: relax Debug/Clone bounds #889

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

Philippe-Cholet
Copy link
Member

@Philippe-Cholet Philippe-Cholet commented Feb 28, 2024

Derive those adds a bound on U which is not needed (I checked with the "expand macros" tool of the Rust playground) since it's only PhantomData.
Note that PhantomData<T> is Debug + Clone for any T.

I can hit easily hit the error (playground).

Derive those adds a bound on `U` which is not needed since it's only `PhantomData`.
Note that `PhantomData<T>` is `Debug` for any `T`.
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (6814180) to head (dfa721f).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
+ Coverage   94.38%   94.55%   +0.16%     
==========================================
  Files          48       48              
  Lines        6665     6753      +88     
==========================================
+ Hits         6291     6385      +94     
+ Misses        374      368       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Philippe-Cholet Philippe-Cholet added this to the next milestone Feb 28, 2024
@jswrenn jswrenn added this pull request to the merge queue Feb 28, 2024
Merged via the queue into rust-itertools:master with commit 6b931e5 Feb 28, 2024
13 checks passed
@Philippe-Cholet Philippe-Cholet deleted the mapinto-relax-bounds branch February 28, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants