Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"no-std" categories in "Cargo.toml" #894

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

Philippe-Cholet
Copy link
Member

@Philippe-Cholet Philippe-Cholet commented Mar 6, 2024

This crate can be used in no-std context, with alloc or not.
So I add no-std and no-std::no-alloc to the categories in Cargo.toml.


I checked what is done in similar conditions and found that serde have some similar features

[features]
default = ["std"]
std = []
alloc = []

And has these two categories as well: https://github.com/serde-rs/serde/blob/00c4b0cef80557c33fbcd75fcc70dc034720b4df/serde/Cargo.toml#L6

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (6814180) to head (73c641a).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
+ Coverage   94.38%   94.44%   +0.05%     
==========================================
  Files          48       48              
  Lines        6665     6749      +84     
==========================================
+ Hits         6291     6374      +83     
- Misses        374      375       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jswrenn jswrenn added this pull request to the merge queue Mar 6, 2024
@Philippe-Cholet Philippe-Cholet added this to the next milestone Mar 6, 2024
Merged via the queue into rust-itertools:master with commit 8ed734b Mar 6, 2024
13 checks passed
@Philippe-Cholet Philippe-Cholet deleted the no-std-categories branch March 6, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants