Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings from clippy 1.77 #908

Merged

Conversation

Philippe-Cholet
Copy link
Member

@Philippe-Cholet Philippe-Cholet commented Mar 22, 2024

I triggered CI to see it fail: https://github.com/rust-itertools/itertools/actions/runs/8389675477/job/22976363676
Then I fixed the warnings (denied by CI).

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (6814180) to head (9d297fe).
Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
- Coverage   94.38%   94.35%   -0.03%     
==========================================
  Files          48       48              
  Lines        6665     6807     +142     
==========================================
+ Hits         6291     6423     +132     
- Misses        374      384      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Philippe-Cholet Philippe-Cholet marked this pull request as ready for review March 22, 2024 11:40
@Philippe-Cholet Philippe-Cholet added this to the next milestone Mar 22, 2024
Copy link
Member

@phimuemue phimuemue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Philippe-Cholet Philippe-Cholet added this pull request to the merge queue Mar 22, 2024
Merged via the queue into rust-itertools:master with commit 5cf292f Mar 22, 2024
13 checks passed
@Philippe-Cholet Philippe-Cholet deleted the fix-clippy-1.77 branch March 22, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants