Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add document for scc #80

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Add document for scc #80

merged 2 commits into from
Mar 29, 2023

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Oct 25, 2020

koba-e964
koba-e964 approved these changes Mar 5, 2022
View reviewed changes
Copy link
Collaborator

@koba-e964 koba-e964 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

src/scc.rs Outdated Show resolved Hide resolved
src/scc.rs Outdated Show resolved Hide resolved
@TonalidadeHidrica @koba-e964
Apply suggestions from code review
b622a1b 
Co-authored-by: Hiroki Kobayashi <3303362+koba-e964@users.noreply.github.com>
@qryxip
Copy link
Member Author

qryxip commented Mar 29, 2023

Merging as it's approved.

@qryxip qryxip merged commit c48fcaa into rust-lang-ja:master Mar 29, 2023
@qryxip qryxip deleted the doc-for-scc branch March 29, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba-e964 koba-e964 koba-e964 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qryxip @koba-e964 @TonalidadeHidrica