New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup matching, disallow repeating "types" (closes #23) #26

Merged
merged 1 commit into from Aug 7, 2016

Conversation

Projects
None yet
2 participants
@birkenfeld
Contributor

birkenfeld commented Aug 6, 2016

It is actually not a problem to have repeating instances of links,
foreign_links and errors, the items will just be appended.

To handle the zero-or-one rule for types, we can get away with just
one new matching rule, because there are three cases (no types, empty
types, and fully specified types).

Fixup matching, disallow repeating "types" (closes #23)
It is actually not a problem to have repeating instances of `links`,
`foreign_links` and `errors`, the items will just be appended.

To handle the zero-or-one rule for `types`, we can get away with just
one new matching rule, because there are three cases (no types, empty
types, and fully specified types).

@brson brson merged commit 3a811ee into rust-lang-nursery:master Aug 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brson

This comment has been minimized.

Show comment
Hide comment
@brson

brson Aug 7, 2016

Contributor

Thanks!

Contributor

brson commented Aug 7, 2016

Thanks!

birkenfeld added a commit to birkenfeld/error-chain that referenced this pull request Aug 7, 2016

@birkenfeld birkenfeld deleted the birkenfeld:issue-23 branch Aug 7, 2016

brson added a commit that referenced this pull request Aug 9, 2016

Merge pull request #29 from birkenfeld/fix-tests
Fix stable tests after merge of #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment