New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on stable/beta (closes #12) #28

Merged
merged 1 commit into from Aug 7, 2016

Conversation

Projects
None yet
2 participants
@birkenfeld
Contributor

birkenfeld commented Aug 6, 2016

Apparently, if the macro invocation is the last "expression" in the function block, the parser expects an expression and will not let the macro expand to anything else. Appending a semicolon will disabuse it of that notion.

The breakage only applies to error_chain! usage inside functions, which is probably not relevant other than in these tests.

Seems to be fixed in nightly 1.12 anyway.

Fix tests on stable/beta (closes #12)
Apparently, if the macro invocation is the last "expression" in the
function block, the parser expects an expression and will not let
the macro expand to anything else.  Appending a semicolon will
disabuse it of that notion.

The breakage only applies to error_chain! usage inside functions,
which is probably not relevant other than in these tests.

Seems to be fixed in nightly 1.12 anyway.

@brson brson merged commit 8b27d66 into rust-lang-nursery:master Aug 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brson

This comment has been minimized.

Show comment
Hide comment
@brson

brson Aug 7, 2016

Contributor

Thanks!

Contributor

brson commented Aug 7, 2016

Thanks!

@birkenfeld birkenfeld deleted the birkenfeld:issue-12 branch Aug 7, 2016

@brson brson referenced this pull request Aug 9, 2016

Closed

travis configuration #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment