Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to the nightly feature from crate docs #139

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Jan 15, 2019

Following up for #136

Just removes a reference to the nightly feature (that was removed in #138) from the crate docs.

I thought I'd leave the CI jobs for building and checking on nightly just because it's nice to know whether the nightly channel manages to break in some way so that can get reported back upstream.

cc @Ericson2314

@KodrAus KodrAus merged commit 7765cf3 into rust-lang-nursery:master Jan 15, 2019
@Ericson2314
Copy link
Contributor

Ah so the thing about the nightly jobs is that they do more. The travis one has it alone generate docs, the appveyor one has it alone do some sort of a tests. I agree testing should happen on nightly, but I don't think it should be so distinguished.

@KodrAus KodrAus deleted the chore/remove-nightly-doc branch January 16, 2019 23:07
@KodrAus
Copy link
Contributor Author

KodrAus commented Jan 16, 2019

I think we need to use the nightly channel for the compile tests, because the infrastructure that runs them requires it.

As for docs generation, I wonder if we need to do it all now that docs.rs is ubiquitous. I guess it doesn't hurt.

@BurntSushi
Copy link
Member

As for docs generation, I wonder if we need to do it all now that docs.rs is ubiquitous. I guess it doesn't hurt.

FWIW, I stopped doing it for the regex crate and just rely on docs.rs. So if you need precedent, feel free to use me. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants