Upgraded spin to 0.7 for better performance #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #181 |
|
@KodrAus Any chance of this getting merged? Also, what do you think about using |
|
Sorry for the delay here @zesterer! 🙇 This looks good to me. |
|
As a point of interest: |
|
Also adding this here : |
kayabaNerve
added a commit
to serai-dex/serai
that referenced
this pull request
Oct 16, 2023
Requires a git dependency due to rust-lang-nursery/lazy-static.rs#201. Justified due to bumping the internally spin to 0.9 (containing a bug fix for 0.9 in general (rust-lang-nursery/lazy-static.rs#199)), surpassing 0.7 (offering performance (rust-lang-nursery/lazy-static.rs#182)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spin0.7 includes performance improvements such as less strict ordering requirements and better spinning. All in all, this should reduce power consumption and improve performance, particularly on platforms like ARM.