Replace Option<T> with MaybeUninit<T>
#192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids unneeded tag in `Option` and addresses FIXME comment.
|
Perhaps this should bump the minimally supported version from 1.27.2 to 1.36.0: diff --git a/.travis.yml b/.travis.yml
index ae60bd2..67b5787 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,7 +1,7 @@
language: rust
matrix:
include:
- - rust: 1.27.2
+ - rust: 1.36.0
script:
- cargo test --tests
- rust: stable
diff --git a/README.md b/README.md
index 5729f4e..7f43e8c 100644
--- a/README.md
+++ b/README.md
@@ -15,7 +15,7 @@ as well as anything that requires non-const function calls to be computed.
## Minimum supported `rustc`
-`1.27.2+`
+`1.36.0+`
This version is explicitly tested in CI and may only be bumped in new minor versions. Any changes to the supported minimum version will be called out in the release notes.
|
|
Oh, I'm not sure why I didn't notice that. Perhaps "stable since 1.36" confused me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids unneeded tag in
Optionand addresses FIXME comment.