Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinning no_std feature #46

Merged
merged 5 commits into from Apr 27, 2016
Merged

Spinning no_std feature #46

merged 5 commits into from Apr 27, 2016

Conversation

Ericson2314
Copy link
Contributor

Fixes #44

@Ericson2314
Copy link
Contributor Author

Ok, added a commit to get travis to test this feature too.

@Kimundi Kimundi merged commit 2005102 into rust-lang-nursery:master Apr 27, 2016
@Kimundi
Copy link
Contributor

Kimundi commented Apr 27, 2016

Thanks!

@jethrogb
Copy link

jethrogb commented May 9, 2016

This change should've been accompanied by a minor version bump to avoid breakage.

@Ericson2314
Copy link
Contributor Author

What broke? I didn't think I had changed any intentionally-public interfaces.

@jethrogb
Copy link

jethrogb commented May 9, 2016

Sorry, disregard. I was confused by commit b230b7a and the reverse chronological order of the commits in the PR screen and I thought there used to be a no_std feature that was renamed.

@Ericson2314
Copy link
Contributor Author

Ah, yeah the way github presents commits in PR threads is super confusing.

@Ryman Ryman mentioned this pull request May 14, 2016
@BurntSushi
Copy link
Member

FYI, I think this PR caused the minimum Rust version for lazy_static to increase with the use of #![no_std]. (The policy of whether that's allowed in a minor semver bump is currently being debated: rust-lang/rfcs#1619)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants