Add bindgen::Builder::derive_copy to control whether we emit derive(Copy) on type definitions

[ctaggart]

I'm getting a lot of errors like the trait Copy may not be implemented for this type, so I went to disable it like I did for .derive_debug, but there isn't an option to turn it off. Shouldn't there be?

    let mut builder = bindgen::Builder::default()
        .header("src/octhc.h")
        // .... snip ...
        .derive_debug(false)
        // .derive_copy(false)
        .whitelist_recursively(false)
        .layout_tests(false)
        .generate_comments(false);

[emilio]

Probably, yeah... Ideally shouldn't be needed. This is basically a dupe of #944.

Right now the analysis landed in #866 assumed that everything not whitelisted should assume to derive copy, when it should be the other way around.

[fitzgen]

It should be pretty straightforward to add a fn derive_copy(mut self, doit: bool) -> Self method to Builder. One could look at how its done for derive_debug to see how to thread the pieces together.

Happy to mentor anyone who wants to take this.

[highfive]

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

[fitzgen]

Probably, yeah... Ideally shouldn't be needed. This is basically a dupe of #944.

Right now the analysis landed in #866 assumed that everything not whitelisted should assume to derive copy, when it should be the other way around.

That is certainly a bug, but it also makes sense to allow people to avoid deriving Copy in general. In other words, this isn't a dupe in my opinion.

[mchlrhw]

@fitzgen I'd be happy to help out with this. Just getting into Rust and looking for ways to contribute in my spare time. I've opened a PR for this containing some trivial changes. Will need some help with the rest.

[mchlrhw]

@highfive: assign me

[highfive]

Hey @mchlrhw! Thanks for your interest in working on this issue. It's now assigned to you!