Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC - error_chain in some examples is quite noisy #106

Closed
budziq opened this issue May 17, 2017 · 0 comments
Closed

RFC - error_chain in some examples is quite noisy #106

budziq opened this issue May 17, 2017 · 0 comments

Comments

@budziq
Copy link
Collaborator

budziq commented May 17, 2017

@dtolnay Hi after switching all examples with fn run() to error_chain some of the examples became quite noisy eg http://localhost:3000/net.html#parse-a-url-from-a-string-to-a-url-type
has 8 lines of code to 9 lines of error_chain maiking it hard to read

I think that we could have best of both worlds (completely copy-pastable examples and minimal noise) if we have used the expand collapse button (currently hidden along with play button) and hide the error_chain and main boiler plate by default (and be able to show it on click).

I will prepare a minimal PR for your consideration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants