Read csv records with different delimeter #235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisha17
force-pushed
the
csv_delimiter
branch
2 times, most recently
from
ad39750
to
5815f20
Compare
budziq
requested changes
Jul 11, 2017
src/encoding.md
Outdated
| use csv::ReaderBuilder; | ||
| use std::process; | ||
|
|
||
| fn run() -> Result<(), Box<Error>> { |
There was a problem hiding this comment.
please do not use Box. We prefer error_chain for the sake of conformity
src/encoding.md
Outdated
| Ok(()) | ||
| } | ||
|
|
||
| fn main() { |
There was a problem hiding this comment.
PLease use error_chain's quick_main
src/encoding.md
Outdated
| use std::process; | ||
|
|
||
| fn run() -> Result<(), Box<Error>> { | ||
| let data = "\ |
There was a problem hiding this comment.
is the extra linebreak needed here?
src/encoding.md
Outdated
| Mark-Melbourne-46 | ||
| Ashley-Zurich-92"; | ||
|
|
||
| let mut reader = ReaderBuilder::new().delimiter(b'-').from_reader(data.as_bytes()); |
There was a problem hiding this comment.
please mention and link the delimiter method
src/encoding.md
Outdated
|
|
||
| let mut reader = ReaderBuilder::new().delimiter(b'-').from_reader(data.as_bytes()); | ||
| for result in reader.records() { | ||
| let record = result?; |
There was a problem hiding this comment.
do we need this extra line? why not use ? inside the println!?
|
Looks good but needs a rebase to deal with the merge conflict. |
|
I rebased and merged manually. thanks @alisha17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #229