Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRead csv records with different delimeter #235
Conversation
alisha17
force-pushed the
alisha17:csv_delimiter
branch
2 times, most recently
from
ad39750
to
5815f20
Jul 10, 2017
budziq
requested changes
Jul 11, 2017
src/encoding.md
Outdated
| use csv::ReaderBuilder; | ||
| use std::process; | ||
| fn run() -> Result<(), Box<Error>> { |
This comment has been minimized.
This comment has been minimized.
budziq
Jul 11, 2017
Collaborator
please do not use Box. We prefer error_chain for the sake of conformity
src/encoding.md
Outdated
| use std::process; | ||
| fn run() -> Result<(), Box<Error>> { | ||
| let data = "\ |
This comment has been minimized.
This comment has been minimized.
src/encoding.md
Outdated
| Mark-Melbourne-46 | ||
| Ashley-Zurich-92"; | ||
| let mut reader = ReaderBuilder::new().delimiter(b'-').from_reader(data.as_bytes()); |
This comment has been minimized.
This comment has been minimized.
src/encoding.md
Outdated
| let mut reader = ReaderBuilder::new().delimiter(b'-').from_reader(data.as_bytes()); | ||
| for result in reader.records() { | ||
| let record = result?; |
This comment has been minimized.
This comment has been minimized.
alisha17
force-pushed the
alisha17:csv_delimiter
branch
from
53748af
to
fa47ae2
Jul 15, 2017
This comment has been minimized.
This comment has been minimized.
|
Looks good but needs a rebase to deal with the merge conflict. |
alisha17
force-pushed the
alisha17:csv_delimiter
branch
from
fa47ae2
to
e4db551
Jul 19, 2017
This comment has been minimized.
This comment has been minimized.
|
I rebased and merged manually. thanks @alisha17 |
brson
closed this
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alisha17 commentedJul 10, 2017
•
edited
fixes #229