Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Redirect both stdout and stderr of child process to the same fle" #349

Merged
merged 1 commit into from Oct 31, 2017
Merged

Add "Redirect both stdout and stderr of child process to the same fle" #349

merged 1 commit into from Oct 31, 2017

Conversation

ludwigpacifici
Copy link
Contributor

fixes #345

@ludwigpacifici
Copy link
Contributor Author

Hello @budziq

I change the command from find / (what I suggested in #345) tols. The execution time is quicker.

Also, I hardcoded the filename. I saw a crate to create temporaries, but the example would be less minimal.

Let me know your thoughts.

budziq
budziq requested changes Oct 30, 2017
View reviewed changes
Copy link
Collaborator

@budziq budziq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just some minor suggestions below.

src/basics.md Outdated

[![std-badge]][std] [![cat-os-badge]][cat-os]

Spawns a Unix command and redirects `stdout` and `stderr` to the same
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The api itself is cross platform so I would avoid mentioning unix here. Would rather go with child processes.

src/basics.md Outdated
used to reference the same file for `stdout` and `stderr`.

The below recipe is equivalent to run `ls . oops &> out.txt`.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we can mention that the example would be equivalent to following Unix shell command.

src/basics.md Outdated
Spawns a Unix command and redirects `stdout` and `stderr` to the same
file. It follows the same idea as [run piped external
commands](#ex-run-piped-external-commands), however [`process::Stdio`]
will be constructed from a file. In addition, [`File::try_clone`] is
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the statement might be slightly misleading. we might want to rewrite to emphasize that process::Stdio will write to provided Fileand that File::try_clone will duplicate the file handle ensuring the write pointer is synchronized for stderr and stdout

@ludwigpacifici
Copy link
Contributor Author

@budziq, PR updated with your comments.

I also changed changed the equivalent Unix command from ls . oops &> out.txt to
ls . oops >out.txt 2>&1. The former may not be compatible and the later is more standard.

@budziq budziq merged commit 0ecf0bf into rust-lang-nursery:master Oct 31, 2017
@budziq
Copy link
Collaborator

budziq commented Oct 31, 2017

Well done!

@ludwigpacifici
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budziq budziq budziq requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Redirect both stdout and stderr of child process to the same file" example
2 participants
@ludwigpacifici @budziq