Implements "Log to the Unix syslog" example #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
reviewed
May 11, 2017
src/app.md
Outdated
| Messages are logged to [UNIX syslog]. Logger backend is initialized | ||
| with [`syslog::init`]. | ||
| [`syslog::Facility`] indicates type of program submitting log. | ||
| [`log::LogLevelFilter`] denotes alowed log verbosity |
src/app.md
Outdated
| with [`syslog::init`]. | ||
| [`syslog::Facility`] indicates type of program submitting log. | ||
| [`log::LogLevelFilter`] denotes alowed log verbosity | ||
| and `Option<&str>` holds optional aplication name. |
There was a problem hiding this comment.
"aplication" should be "application"
src/app.md
Outdated
| [`log::LogLevelFilter`] denotes alowed log verbosity | ||
| and `Option<&str>` holds optional aplication name. | ||
|
|
||
| ```rust,no_run |
There was a problem hiding this comment.
Why is this no_run? Is there some reason it would fail if run in CI?
There was a problem hiding this comment.
Thanks for your time :)
it is marked as no_run in order not to clobber the syslog. I guess that most people would prefer not to have noise in their syslog at every testrun.
The example is marked as no_run in order not to clobber the actual on each test run
|
@dtolnay typos fixed (sorry for that 😞). The example itself is still |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see https://github.com/brson/rust-cookbook/issues/61