Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Causal error messages are not great! #991

Open
brson opened this issue Mar 16, 2017 · 2 comments
Open

Causal error messages are not great! #991

brson opened this issue Mar 16, 2017 · 2 comments

Comments

@brson
Copy link
Contributor

brson commented Mar 16, 2017

brian@DESKTOP-CODN6ST MINGW64 /c/Users/brian/Documents/dev/taskcluster-crater/rs
$ rustup update stable
info: syncing channel updates for 'stable-x86_64-pc-windows-msvc'
info: downloading component 'rustc'
info: downloading component 'rust-std'
info: downloading component 'cargo'
info: downloading component 'rust-std' for 'armv7-apple-ios'
info: downloading component 'rust-std' for 'i686-apple-darwin'
error: component download failed for rust-std-i686-apple-darwin
info: caused by: could not download file from 'https://static.rust-lang.org/dist/2017-03-11/rust-std-1.16.0-i686-apple-darwin.tar.gz' to 'C:\Users\brian\.rustup\tmp\4y0bss25meytiiyq_file
info: caused by: error during download
info: caused by: [18] Transferred a partial file (transfer closed with 3544136 bytes remaining to read)

Here it's on the 4th line back that we're told there's an error. All subsequent lines just claim to be 'info', and the info lines contain double-colons!

This needs some custom formatting that clearly indicates all this is error stuff.

@ecumene
Copy link
Contributor

ecumene commented Oct 1, 2019

I'd like to contribute!

I'm confused by what OP means by "and the info lines contain double-colons!", how should these messages be rendered? Something like this?

error caused by: could not download file from 'https://static.rust-lang.org/dist/2017-03-11/rust-std-1.16.0-i686-apple-darwin.tar.gz' to 'C:\Users\brian\.rustup\tmp\4y0bss25meytiiyq_file
error caused by: caused by: error during download
error caused by: [18] Transferred a partial file (transfer closed with 3544136 bytes remaining to read)

@kinnison
Copy link
Contributor

kinnison commented Oct 2, 2019

The prefix: caused by: continuation form isn't beautiful, but I'm not sure what'd be nicer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants