Don't require a UUID in Mach-O binaries #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winterqt
force-pushed
the
macho-with-no-uuid
branch
from
8e4cc0f
to
95041fc
Compare
winterqt
changed the title
|
Nice find, thanks! Would you be up for adding a test for this as well? (it'd be a macos-specific test that would probably run the test suite with the |
winterqt
force-pushed
the
macho-with-no-uuid
branch
from
95041fc
to
3a66cac
Compare
Done :) |
winterqt
force-pushed
the
macho-with-no-uuid
branch
from
3a66cac
to
bd1ff81
Compare
|
Thanks! |
winterqt
added a commit
to winterqt/rust
that referenced
this pull request
Oct 18, 2021
rust-lang/backtrace-rs#446 allows binaries built with Nix on macOS to be symbolized.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 18, 2021
…ulacrum Bump backtrace rust-lang/backtrace-rs#446 allows binaries built with Nix on macOS to be symbolized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Mach-O binaries do not contain the
LC_UUIDcommand, such as those built with Nix, so this PR removes the requirement for one to exist.This fixes #443.