Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad Parameter naming. #3142

Closed
punishell opened this issue May 6, 2022 · 0 comments
Closed

Bad Parameter naming. #3142

punishell opened this issue May 6, 2022 · 0 comments
Milestone
ch12

Comments

@punishell
Copy link

URL to the section(s) of the book with this problem: src/ch12-02-reading-a-file.md

Description of the problem: There is a naming problem here, this function does not take a filename as a parameter but file_path.

Suggested fix:

change it to file_path
@carols10cents carols10cents added this to the ch12 milestone May 9, 2022
carols10cents added a commit that referenced this issue Jun 4, 2022
@carols10cents
More little improvements to chapter 12
a9fb154 
- Change the variable name from filename to file_path. Fixes #3142.
- Use the new println capture. Connects to #3048.
- Use dbg! when appropriate. Connects to #2842.
- Improve the expect message to read better. Connects to #2918.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ch12
Development

No branches or pull requests
2 participants
@carols10cents @punishell