Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casting from a pointer should have type 'usize', not 'i32'. #866

Merged
merged 2 commits into from Aug 5, 2017

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Aug 4, 2017

@cramertj
Copy link
Member

cramertj commented Aug 4, 2017

Seems like it should be usize, no?

@frewsxcv frewsxcv changed the title Casting from a pointer should have type 'isize', not 'i32'. Casting from a pointer should have type 'usize', not 'i32'. Aug 4, 2017
@frewsxcv
Copy link
Member Author

frewsxcv commented Aug 4, 2017

woops yeah

Copy link
Member

@carols10cents carols10cents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oopsie!!! Thank you!!!

@carols10cents carols10cents merged commit 9220d4a into master Aug 5, 2017
@carols10cents carols10cents deleted the frewsxcv-casting branch August 5, 2017 14:54
carols10cents pushed a commit to frewsxcv/rust that referenced this pull request Aug 5, 2017
Primarily to pick up this change:

rust-lang/book#866

...to move this PR forward:

rust-lang#43641
bors added a commit to rust-lang/rust that referenced this pull request Aug 5, 2017
Bump 'src/doc/book' git submodule.

Primarily to pick up this change:

rust-lang/book#866

...to move this PR forward:

#43641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants