Auto merge of #5122 - acmcarther:acm-emit-features-from-cargo-metadat…

…a, r=alexcrichton

Emit Resolve.features_sorted in "cargo metadata"

This PR adds `features` to `metadata.resolve.nodes[*]` using the Resolve object's known features. This is different from the `features` fields that already exist elsewhere within metadata as this one is the actual features that need to be used in order to build the code.

Context: I'm currently using Cargo's internals to synthesize BUILD files for the Bazel build tool. `cargo metadata` currently provides almost everything I need in order to avoid using Cargo's internals -- *except* for this.

cc google/cargo-raze#7

src/cargo/ops/cargo_output_metadata.rs

@@ -98,12 +98,14 @@ fn serialize_resolve<S>(resolve: &Resolve, s: S) -> Result<S::Ok, S::Error>
     struct Node<'a> {
         id: &'a PackageId,
         dependencies: Vec<&'a PackageId>,
+        features: Vec<&'a str>,
     }
 
     resolve.iter().map(|id| {
         Node {
             id,
             dependencies: resolve.deps(id).collect(),
+            features: resolve.features_sorted(id),
         }
     }).collect::<Vec<_>>().serialize(s)
 }

tests/testsuite/metadata.rs

@@ -42,6 +42,7 @@ fn cargo_metadata_simple() {
             "nodes": [
                 {
                     "dependencies": [],
+                    "features": [],
                     "id": "foo 0.5.0 (path+file:[..]foo)"
                 }
             ],
@@ -117,6 +118,77 @@ crate-type = ["lib", "staticlib"]
             "nodes": [
                 {
                     "dependencies": [],
+                    "features": [],
+                    "id": "foo 0.5.0 (path+file:[..]foo)"
+                }
+            ],
+            "root": "foo 0.5.0 (path+file:[..]foo)"
+        },
+        "target_directory": "[..]foo[/]target",
+        "version": 1,
+        "workspace_root": "[..][/]foo"
+    }"#));
+}
+
+#[test]
+fn library_with_features() {
+    let p = project("foo")
+        .file("src/lib.rs", "")
+        .file("Cargo.toml", r#"
+[package]
+name = "foo"
+version = "0.5.0"
+
+[features]
+default = ["default_feat"]
+default_feat = []
+optional_feat = []
+            "#)
+        .build();
+
+    assert_that(p.cargo("metadata"), execs().with_json(r#"
+    {
+        "packages": [
+            {
+                "name": "foo",
+                "version": "0.5.0",
+                "id": "foo[..]",
+                "source": null,
+                "dependencies": [],
+                "license": null,
+                "license_file": null,
+                "description": null,
+                "targets": [
+                    {
+                        "kind": [
+                            "lib"
+                        ],
+                        "crate_types": [
+                            "lib"
+                        ],
+                        "name": "foo",
+                        "src_path": "[..][/]foo[/]src[/]lib.rs"
+                    }
+                ],
+                "features": {
+                  "default": [
+                    "default_feat"
+                  ],
+                  "default_feat": [],
+                  "optional_feat": []
+                },
+                "manifest_path": "[..]Cargo.toml"
+            }
+        ],
+        "workspace_members": ["foo 0.5.0 (path+file:[..]foo)"],
+        "resolve": {
+            "nodes": [
+                {
+                    "dependencies": [],
+                    "features": [
+                      "default",
+                      "default_feat"
+                    ],
                     "id": "foo 0.5.0 (path+file:[..]foo)"
                 }
             ],
@@ -260,16 +332,19 @@ fn cargo_metadata_with_deps_and_version() {
                     "dependencies": [
                         "bar 0.0.1 (registry+[..])"
                     ],
+                    "features": [],
                     "id": "foo 0.5.0 (path+file:[..]foo)"
                 },
                 {
                     "dependencies": [
                         "baz 0.0.1 (registry+[..])"
                     ],
+                    "features": [],
                     "id": "bar 0.0.1 (registry+[..])"
                 },
                 {
                     "dependencies": [],
+                    "features": [],
                     "id": "baz 0.0.1 (registry+[..])"
                 }
             ],
@@ -334,6 +409,7 @@ name = "ex"
             "nodes": [
                 {
                     "id": "foo 0.1.0 (path+file:[..]foo)",
+                    "features": [],
                     "dependencies": []
                 }
             ]
@@ -398,6 +474,7 @@ crate-type = ["rlib", "dylib"]
             "nodes": [
                 {
                     "id": "foo 0.1.0 (path+file:[..]foo)",
+                    "features": [],
                     "dependencies": []
                 }
             ]
@@ -470,10 +547,12 @@ fn workspace_metadata() {
             "nodes": [
                 {
                     "dependencies": [],
+                    "features": [],
                     "id": "baz 0.5.0 (path+file:[..]baz)"
                 },
                 {
                     "dependencies": [],
+                    "features": [],
                     "id": "bar 0.5.0 (path+file:[..]bar)"
                 }
             ],