Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo vendor doesn't respect symbolic links #10251

Open
pcwalton opened this issue Jan 3, 2022 · 2 comments
Open

cargo vendor doesn't respect symbolic links #10251

pcwalton opened this issue Jan 3, 2022 · 2 comments
Labels
A-filesystem Area: issues with filesystems C-bug Category: bug Command-vendor S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.

Comments

@pcwalton
Copy link

pcwalton commented Jan 3, 2022

Problem

The function that cargo vendor uses to copy files doesn't respect symbolic links: https://github.com/rust-lang/cargo/blob/master/src/cargo/ops/vendor.rs#L354

This causes cargo vendor to fail if there are any broken symbolic links in the crate it's trying to vendor.

Steps

$ cargo new blahblah
$ cd blahblah
$ echo 'rsdd = { git = "https://github.com/SHoltzen/rsdd", rev = "28ba18d3" }' >> Cargo.toml
$ cargo vendor test

Possible Solution(s)

Make that function respect symbolic links.

Notes

No response

Version

cargo 1.57.0-nightly (d56b42c54 2021-09-27)
release: 1.57.0
commit-hash: d56b42c549dbb7e7d0f712c51b39400260d114d4
commit-date: 2021-09-27
@jmintb
Copy link

jmintb commented Oct 31, 2022

Can I have a crack at this?

@Muscraft
Copy link
Contributor

Muscraft commented Nov 1, 2022

I would hold off on working on this as we are looking into a fix for #11192 and it may resolve this issue as well.

@weihanglo weihanglo added S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted. A-filesystem Area: issues with filesystems and removed E-help-wanted labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-filesystem Area: issues with filesystems C-bug Category: bug Command-vendor S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.
Projects
None yet
Development

No branches or pull requests

5 participants