Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for update --precise with pre-release #13290

Open
1 task
ehuss opened this issue Jan 13, 2024 · 5 comments
Open
1 task

Tracking Issue for update --precise with pre-release #13290

ehuss opened this issue Jan 13, 2024 · 5 comments
Labels
C-tracking-issue Category: A tracking issue for something unstable. Command-update S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review

Comments

@ehuss
Copy link
Contributor

ehuss commented Jan 13, 2024 •
edited by weihanglo

Summary

RFC: #3493
Original issue: #12579
Implementation: #13626
Documentation: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#precise-pre-release

Extends cargo update --precise to allow pre-release versions, even if the dependency declarations do not specify a pre-release.

Unresolved Issues

  • Upstream pre-release match logic to semver crate?

Future Extensions

No response

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
@ehuss ehuss added Command-update S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing. C-tracking-issue Category: A tracking issue for something unstable. labels Jan 13, 2024
@ehuss ehuss mentioned this issue Jan 13, 2024
Merged
@ehuss ehuss added S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review and removed S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing. labels Jan 13, 2024
@eopb eopb mentioned this issue Jan 14, 2024
Open
eopb added a commit to eopb/cargo that referenced this issue Jan 14, 2024
@eopb
Introduce -Zprecise-pre-release unstable flag
5a910b6 
Tracking Issue: [rust-lang#13290](rust-lang/rust#13290)

This change introduces the feature but does not yet attempt an implementation.
The actual implementation will happen in future PRs

r? @epage
@eopb eopb mentioned this issue Jan 14, 2024
Merged
bors added a commit that referenced this issue Jan 15, 2024
@bors
Auto merge of #13296 - eopb:precise-pre-release-flag, r=epage
19eb0f0 
Introduce `-Zprecise-pre-release` unstable flag

Tracking Issue: [#13290](#13290)

This change introduces the feature but does not yet attempt an implementation. The actual implementation will happen in future PRs.

r? `@epage`
@epage epage changed the title Tracking Issue for precise pre-release update Tracking Issue for update --precise with pre-release Feb 8, 2024
@linyihai
Copy link
Contributor

linyihai commented Mar 4, 2024

Since #13296 had merged, i think i can lend a hand to continue.

Just in case I forgot, I was gonna @rustbot claim.

@epage
Copy link
Contributor

epage commented Mar 4, 2024

I believe @eopb was planning on working on this. I'd recommend coordinating with them

@epage epage mentioned this issue Mar 5, 2024
Open
@eopb
Copy link
Contributor

eopb commented Mar 6, 2024 •
edited

Thanks Ed. Yes, I'm still intending to work on this. If you'd like to help @linyihai, please reach out to me on zulip (under the same username as here).

I'm sure we can work together. The last thing I'd want to do is to slow things down by trying to hog this tracking issue.

@linyihai linyihai removed their assignment Mar 7, 2024
@linyihai
Copy link
Contributor

linyihai commented Mar 7, 2024

Yes, I'm still intending to work on this. I'm sure we can work together. The last thing I'd want to do is to slow things down by trying to hog this tracking issue.

I'm sorry that I started the claim without further understanding of the requirement. You're the one who came up with this RFC, so I'm sure you know more details than I do. If you think it's better to do it yourself, that's fine. If you need help, break it down into smaller issues so that others see it and can help @eopb

please reach out to me on zulip (under the same username as here).

I'll be in touch if I need anything. Thank you @eopb

@linyihai
Copy link
Contributor

FYI，I recently tried to implement an MVP based on RFC content.

@linyihai linyihai mentioned this issue Mar 22, 2024
Merged
bors added a commit that referenced this issue Apr 3, 2024
@bors
Auto merge of #13626 - linyihai:pre-update, r=weihanglo
6774b85 
Allow precise update to prerelease.

### What does this PR try to resolve?

This is a feature that attempts to support updates to pre-release versions via `cargo update --precise`.

when `precise-pre-release` used, the prerelase version will be taking consider as compatible version.  That said, we can update to any compatible pre-release version. The logic of checking the compatibility of pre-release versions is currently tentative and does not take many conditions into account, this part of the logic makes more sense when implemented in semver.

Use `-Zunstable-options`  instead of  `-Zprecise-pre-release`.

### How should we test and review this PR?

### Additional information
Part of #13290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: A tracking issue for something unstable. Command-update S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review
Projects
Cargo Roadmap
Status: Big Projects, no backers
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ehuss @epage @eopb @linyihai