"cargo publish" should error if there are path overrides

[erickt]

This might result in builds that succeed on the local machine, but fail when someone else tries to build the crate.

[alexcrichton]

Indeed! Or it should just ignore them.

[eminence]

Triage: I tested this scenario today and it seems like path dependencies are ignored during publish (meaning cargo will pull that dependency from the registry, not from the path in Cargo.toml). Same with patch overrides. I wasn't able to immeditally find the commit that implemented this, though.

[ehuss]

@eminence I believe this is referring to paths overrides, which are defined in config.toml. The package verification step still uses those overrides, when it probably shouldn't.

[eminence]

Ahyes, I see. Thank you @ehuss for that clarification.

[hi-rustin]

@weihanglo Is this issue S-accepted ? It looks interesting. Can I pick it up and try to improve it?

[weihanglo]

It is S-needs-mentor, which means we may or may not have time mentoring and reviewing it. It might be okay as you're already familiar with the codebase.