Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo publish should warn/error on unknown settings in Cargo.toml #3576

Closed
Susurrus opened this issue Jan 22, 2017 · 2 comments
Closed

Cargo publish should warn/error on unknown settings in Cargo.toml #3576

Susurrus opened this issue Jan 22, 2017 · 2 comments
Labels
A-diagnostics Area: Error and warning messages generated by Cargo itself. A-manifest Area: Cargo.toml issues S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.

Comments

@Susurrus
Copy link
Contributor

I recently tried to publish both category and badge information for some of my crates. I couldn't figure out why this information wasn't being displayed on crates.io, and eventually I figured out that I was using an old version of cargo. If cargo warned on values that it didn't understand when running publish I think this could have been avoided. I'm not certain if very many people put custom things in their Cargo.toml and some crates use that, but I think in general it'd be good to have the package namespace locked down like that. This wouldn't have caught the problem with the new badges namespace, but that might cause too many false positives.

What infrastructure is proposed to resolve this probably overlaps with #2489.

@epage
Copy link
Contributor

epage commented May 24, 2023

See also #5264

@weihanglo weihanglo added S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted. A-manifest Area: Cargo.toml issues and removed S-triage Status: This issue is waiting on initial triage. labels Aug 16, 2023
@epage
Copy link
Contributor

epage commented Oct 11, 2023

This issue has been opened for a while and, as pointed out in #5264, we have warnings now on unused fields and if there are specific problems people run into where we are not giving warnings, we welcome people to create issues about them.

I've confirmed that categories and badges typos give warnings. As such I'm going to go ahead and close this.

@epage epage closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Error and warning messages generated by Cargo itself. A-manifest Area: Cargo.toml issues S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.
Projects
None yet
Development

No branches or pull requests

4 participants