Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.metadata does not appear in cargo metadata output #4819

Closed
euclio opened this issue Dec 14, 2017 · 1 comment · Fixed by #5360
Closed

package.metadata does not appear in cargo metadata output #4819

euclio opened this issue Dec 14, 2017 · 1 comment · Fixed by #5360
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`

Comments

@euclio
Copy link
Contributor

euclio commented Dec 14, 2017

Is this intentional? I would expect that table to be included in the JSON.
@alexcrichton
Copy link
Member

cargo metadata is mostly just conservative right now, there's no particular reason it's been omitted.

@alexcrichton alexcrichton added the C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` label Dec 15, 2017
euclio added a commit to euclio/cargo that referenced this issue Apr 14, 2018
@euclio
include package metadata in cargo metadata
2efeeda 
Fixes rust-lang#4819.
@euclio euclio mentioned this issue Apr 14, 2018
Merged
bors added a commit that referenced this issue Apr 16, 2018
@bors
Auto merge of #5360 - euclio:metadata, r=alexcrichton
6cc4780 
include package metadata in `cargo metadata`

Fixes #4819.

All-in-all a pretty small change. I'm a little concerned about threading the `toml::Value` all the way through however, should I make another type? Also, cloning the metadata value initially is maybe not ideal, since it's technically accessible through the original manifest. I figured this way was cleaner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

include package metadata in cargo metadata euclio/cargo
2 participants
@alexcrichton @euclio