New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run cross_compile::build_deps_for_the_right_arch test first #5141
Comments
As there hasn't been any activity here in over 6 months I've marked this as stale and if no further activity happens for 7 days I will close it. I'm a bot so this may be in error! If this issue should remain open, could someone (the author, a team member, or any interested party) please comment to that effect? The team would be especially grateful if such a comment included details such as:
Thank you for contributing! If you're reading this comment from the distant future, fear not if this was closed automatically. If you believe it's still an issue please leave a comment and a team member can reopen this issue. Opening a new issue is also acceptable! |
This issue is still marked as stale although it was referenced by a fix. |
I think you need to "fix" GitHub for that, as stale bot only relies on the issue's updated timestamp. But actually I think referencing is fine to not update an issue. I kind of intentionally sent a PR without touching this issue, as if my proposed fix isn't accepted I'm not sure how else to solve this issue, so I'm happy for it to close out as stale. |
…r=alexcrichton Run the cross-compile disable check ASAP Fixes #5141
Hmm, what I actually wanted was that the entire testsuit would immediately interrupt once it hits this failure (and prints the stderr).
|
I'd be happy to look into doing that if a maintainer were to confirm that change in testing behaviour is acceptable. |
I feel like that's the same story for all tests written in Rust? With hundreds of test if only the first one fails it takes awhile to see the error? I'm not sure why we'd special case these tests to fail even faster Alternatively we could add an option to Rust's libtest like |
cross_compile::build_deps_for_the_right_arch fails on my system and it always prints
and then I re-run the tests with CFG_DISABLE_CROSS_TESTS=1
Can we run this test before all other tests to make sure we don't have to rerun the half the testsuit if it fails?
The text was updated successfully, but these errors were encountered: