Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TomlProject.version field should be stored directly as a Version, to enable better error messages #54

Closed
huonw opened this issue Jun 25, 2014 · 0 comments · Fixed by #444
Closed

TomlProject.version field should be stored directly as a Version, to enable better error messages #54

huonw opened this issue Jun 25, 2014 · 0 comments · Fixed by #444

Comments

@huonw
Copy link
Member

huonw commented Jun 25, 2014

Marked in the code with a fixme.

I believe this would either require replacing some of the #[deriving(Decodable)] instances in util::toml with manual ones, or fixing rust-lang/rust#15036.
alexcrichton added a commit to alexcrichton/cargo that referenced this issue Aug 26, 2014
@alexcrichton
Decode directly into a semver::Version
2c3fa2d 
This generates errors for malformed semver versions during the decoding process
rather than later in the convertion to a package id. This also cuts down on the
large number of derived traits to only what's necessary.

Closes rust-lang#54
@alexcrichton alexcrichton mentioned this issue Aug 26, 2014
Merged
bors added a commit that referenced this issue Aug 27, 2014
@bors
auto merge of #444 : alexcrichton/cargo/issue-54, r=brson
caca3af 
This generates errors for malformed semver versions during the decoding process
rather than later in the convertion to a package id. This also cuts down on the
large number of derived traits to only what's necessary.

Closes #54
@bors bors closed this as completed in #444 Aug 27, 2014
alexcrichton added a commit to alexcrichton/cargo that referenced this issue Sep 2, 2014
@alexcrichton
Decode directly into a semver::Version
eebbfa0 
This generates errors for malformed semver versions during the decoding process
rather than later in the convertion to a package id. This also cuts down on the
large number of derived traits to only what's necessary.

Closes rust-lang#54
bors added a commit to alexcrichton/cargo that referenced this issue Sep 2, 2014
@bors
auto merge of rust-lang#444 : alexcrichton/cargo/issue-54, r=brson
09f5c4d 
This generates errors for malformed semver versions during the decoding process
rather than later in the convertion to a package id. This also cuts down on the
large number of derived traits to only what's necessary.

Closes rust-lang#54
@asomers asomers mentioned this issue Aug 28, 2016
Closed
ehuss pushed a commit to ehuss/cargo that referenced this issue Nov 19, 2023
@bors
Merge rust-lang#54
de63283 
54: Don't loop{} on errors during suggestion parsing r=killercup a=oli-obk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decode directly into a semver::Version alexcrichton/cargo
1 participant
@huonw