Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo --features takes lists in more ways than space-separated #8381

Closed
mulimoen opened this issue Jun 18, 2020 · 2 comments · Fixed by #8433
Closed

cargo --features takes lists in more ways than space-separated #8381

mulimoen opened this issue Jun 18, 2020 · 2 comments · Fixed by #8433
Labels
A-documenting-cargo-itself Area: Cargo's documentation C-bug Category: bug E-easy Experience: Easy

Comments

@mulimoen
Copy link

Problem

Might be a nit-picky, but cargo b --help lists --features as taking a space-separated list of features. The normal way to invoke features seems to be to use a comma-separated list (easier as this does not require quoting when invoking). This is however not documented. Is this supported and should the help text be changed?

Steps

  1. cargo b --features "feat1 feat2"
  2. cargo b --features "feat1,feat2"

Both enable the features feat1 and feat2, using different separators.

Possible Solution(s)

Change the help text in cargo --help for --features to
Space- or comma-separated list of features to activate

Notes

Output of cargo version:
cargo 1.45.0-nightly (40ebd52 2020-06-01)
@mulimoen mulimoen added the C-bug Category: bug label Jun 18, 2020
@mulimoen mulimoen mentioned this issue Jun 18, 2020
Merged
@ehuss
Copy link
Contributor

ehuss commented Jun 25, 2020

It is documented in the man page, just not the built-in help page. Would be happy to accept a PR to update the built-in help!

@ehuss ehuss added A-documenting-cargo-itself Area: Cargo's documentation E-easy Experience: Easy labels Jun 25, 2020
@giraffate
Copy link
Contributor

I'd like to work on this.

@giraffate giraffate mentioned this issue Jun 30, 2020
Merged
bors added a commit that referenced this issue Jul 1, 2020
@bors
Auto merge of #8433 - giraffate:update_built-in_help_for_features, r=…
40550b9 
…alexcrichton

Update built-in help for features

Fixed #8381.
@bors bors closed this as completed in a00b5ac Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-documenting-cargo-itself Area: Cargo's documentation C-bug Category: bug E-easy Experience: Easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update built-in help for features giraffate/cargo
3 participants
@ehuss @mulimoen @giraffate