Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include arbitrary Git submodules when assembling a distributable tarball #943

Closed
IvanUkhov opened this issue Nov 21, 2014 · 2 comments
Closed

Include arbitrary Git submodules when assembling a distributable tarball #943

IvanUkhov opened this issue Nov 21, 2014 · 2 comments

Comments

@IvanUkhov
Copy link
Contributor

Hello,

cargo package does not always take into account all Git submodules of the current project. For example, a top-level submodule needed for a custom build will not be included, and, thus, cargo package will fail unless ran with --no-verify.

It has been suggested that this problem appears when a submodule is not within the path of some local dependency; although, child packages are not supported at all.

Thank you.

Regards,
Ivan
@IvanUkhov IvanUkhov changed the title Arbitrary Git submodules when assembling a distributable tarball Include arbitrary Git submodules when assembling a distributable tarball Nov 21, 2014
@alexcrichton alexcrichton mentioned this issue Jan 6, 2015
Merged
alexcrichton added a commit to alexcrichton/cargo that referenced this issue Jan 8, 2015
@alexcrichton
Update how a PathSource is traversed for git repos
5935ec1 
This fixes a number of bugs along the way:

* Submodules are now recursed into explicitly for packaging, fixing rust-lang#943
* A whitelist has been implemented, fixing rust-lang#880
* Git repos are now always used if there is a package that resides at the root,
  not just if the current package resides at the root.
bors added a commit that referenced this issue Jan 8, 2015
@bors
Auto merge of #1131 - alexcrichton:issue-880, r=brson
8c01b6b 
This fixes a number of bugs along the way:

* Submodules are now recursed into explicitly for packaging, fixing #943
* A whitelist has been implemented, fixing #880
* Git repos are now always used if there is a package that resides at the root,
  not just if the current package resides at the root.
@alexcrichton
Copy link
Member

Fixed in #1131

@IvanUkhov
Copy link
Contributor Author

It has become so much easier to publish. Thanks a lot, Alex!

lucab pushed a commit to lucab/cargo that referenced this issue Jan 25, 2015
@alexcrichton
Update how a PathSource is traversed for git repos
70b1607 
This fixes a number of bugs along the way:

* Submodules are now recursed into explicitly for packaging, fixing rust-lang#943
* A whitelist has been implemented, fixing rust-lang#880
* Git repos are now always used if there is a package that resides at the root,
  not just if the current package resides at the root.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IvanUkhov @alexcrichton