Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Beta] backport "Be resilient to most IO error and filesystem loop while walking dirs" #10286

Merged
merged 1 commit into from Jan 12, 2022
Merged

[Beta] backport "Be resilient to most IO error and filesystem loop while walking dirs" #10286

merged 1 commit into from Jan 12, 2022

Conversation

weihanglo
Copy link
Member

Beta backport of #10214.

@bors @weihanglo
Auto merge of rust-lang#10214 - weihanglo:revert-10188-issue-9528, r=…
7267b05 
…alexcrichton

Be resilient to most IO error and filesystem loop while walking dirs

Let `PathSource::walk` be resilient to most IO errors and filesystem loop.

This PR also

- Add a test validating the resilience against filesystem loop to prevent regression.
- Emit warning when filesystem loop found while walking the filesystem. This is the only way I can think of now to solve rust-lang#9528

Fixes rust-lang#10213.
@rust-highfive
Copy link

r? @ehuss

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.59.0. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 12, 2022
@weihanglo
Copy link
Member Author

r? @alexcrichton

I took other backport PRs as references, but not sure if I did it right.

@rust-highfive rust-highfive assigned alexcrichton and unassigned ehuss Jan 12, 2022
@alexcrichton
Copy link
Member

@bors: r+

Nah looks good! It's basically just a cherry-pick and a PR against the correct branch which looks to all be in order here

@bors
Copy link
Collaborator

bors commented Jan 12, 2022

📌 Commit 7267b05 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2022
@bors
Copy link
Collaborator

bors commented Jan 12, 2022

⌛ Testing commit 7267b05 with merge 2e49328...

@bors
Copy link
Collaborator

bors commented Jan 12, 2022

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing 2e49328 to rust-1.59.0...

@bors bors merged commit 2e49328 into rust-lang:rust-1.59.0 Jan 12, 2022
@weihanglo weihanglo deleted the 1.59.0-beta-backport branch January 13, 2022 03:38
@weihanglo weihanglo mentioned this pull request Jan 13, 2022
Closed
@ehuss ehuss added this to the 1.59.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@weihanglo @rust-highfive @alexcrichton @bors @ehuss