Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable propagating host rustflags to build scripts #10395

Merged
merged 15 commits into from Feb 28, 2022
Merged

Enable propagating host rustflags to build scripts #10395

merged 15 commits into from Feb 28, 2022

Commits on Feb 17, 2022

  1. Run target-applies-to-host tests on stable

    Jon Gjengset committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    90a61d1 View commit details
    Browse the repository at this point in the history

  2. Simplify unused build scripts in tests 

    The tests in question all tail to even build the build script, so the
contents of `main` don't matter, and make the tests seem more complex
than they really are.
    Jon Gjengset committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    040f0d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. Add regression test for rust-lang#10206

    Jon Gjengset committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    fb47df7 View commit details
    Browse the repository at this point in the history

  2. Enable propagating rustflags to build scripts 

    This patch implements more complete logic for applying rustflags to
build scripts and other host artifacts. In the default configuration, it
only makes build scripts (and plugins and whatnot) pick up on
`rustflags` from `[host]`, which fixes rust-lang#10206 but otherwise preserves
existing behavior in all its inconsistent glory. The same is the case if
`target-applies-to-host` is explicitly set to `false`.

When `target-applies-to-host` is explicitly set to `true`, rustflags
will start to be applied in the same way that `linker` and `runner` are
today -- namely they'll be applied from `[target.<host triple>]` and
from `RUSTFLAGS`/`build.rustflags` if `--target <host triple>` is given.
    Jon Gjengset committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    4f41727 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Retain legacy behavior with tath != false

    Jon Gjengset committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    49f90f5 View commit details
    Browse the repository at this point in the history

  2. Fix up doc to reflect latest semantics change

    Jon Gjengset committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    216eeea View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Remove env_var from test names that don't use env

    Jon Gjengset committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    745329c View commit details
    Browse the repository at this point in the history

  2. Make rustflags logic more linear

    Jon Gjengset committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    f23894d View commit details
    Browse the repository at this point in the history

  3. Don't == true

    Jon Gjengset committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    84eb820 View commit details
    Browse the repository at this point in the history

  4. Handle host.rustdocflags

    Jon Gjengset committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    df90291 View commit details
    Browse the repository at this point in the history

  5. Unify logic of legacy and non-legacy code paths

    Jon Gjengset committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    153bca2 View commit details
    Browse the repository at this point in the history

  6. Make rustflags/rustdocflags an enum

    Jon Gjengset committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    4ae6651 View commit details
    Browse the repository at this point in the history

  7. Make docs more accurate

    Jon Gjengset committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    b4ce8a8 View commit details
    Browse the repository at this point in the history

  8. Improve precision of host build.rustflags tests

    Jon Gjengset committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    54674d3 View commit details
    Browse the repository at this point in the history

  9. Avoid #[cfg] duplicated main in tests 

    It makes the logic really hard to follow.
    Jon Gjengset committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    56db829 View commit details
    Browse the repository at this point in the history