Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed small typos #10693

Merged
merged 6 commits into from May 23, 2022
Merged

Fixed small typos #10693

merged 6 commits into from May 23, 2022

Conversation

alex-semenyuk
Copy link
Contributor

Fixed small typos

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 22, 2022
@@ -65,7 +65,7 @@ for more details.

<dl>

<dt class="option-term" id="option-cargo-run--F"><a class="option-anchor" href="#option-cargo-run--F"></a><code>-F</code> <em>features</em></dt>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't seem to be correct. The flag is uppercase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehuss Maybe make sense to remove it, because this option is not mentioned at doc https://doc.rust-lang.org/stable/cargo/commands/cargo-run.html and I don't see it at cargo 1.60.0 (d1fd9fe 2022-03-01) (see just --features)

Copy link
Contributor

@ehuss ehuss May 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a new flag, added in 1.62. The code here has not yet reached stable. You can view the nightly docs by adding nightly to the url like: https://doc.rust-lang.org/nightly/cargo/commands/cargo-run.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehuss Ok, reverted. Curious, is there reason why all options are lowercase and just this is uppercase?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other uppercase options like -Z and -V. I think uppercase -F was chosen to avoid possible confusion with lowercase -f which is often used to mean --force or --file in many unix utilities.

@ehuss
Copy link
Contributor

ehuss commented May 23, 2022

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented May 23, 2022

📌 Commit d48a773 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2022
@bors
Copy link
Collaborator

bors commented May 23, 2022

⌛ Testing commit d48a773 with merge 9bc91ff...

@bors
Copy link
Collaborator

bors commented May 23, 2022

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 9bc91ff to master...

@bors bors merged commit 9bc91ff into rust-lang:master May 23, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2022
Update cargo

10 commits in a4c1cd0eb6b18082a7e693f5a665548fe1534be4..39ad1039d9e3e1746177bf5d134af4c164f95528
2022-05-20 00:55:25 +0000 to 2022-05-25 00:50:02 +0000

* doc: discuss build script instruction order (rust-lang/cargo#10600)
* Require http-registry URLs to end with a '/' (rust-lang/cargo#10698)
* No printing executable names when running tests and benchmarks with json message format (rust-lang/cargo#10691)
* Restore proper error for crate not in local reg (rust-lang/cargo#10683)
* Update libcurl (rust-lang/cargo#10696)
* Fixed small typos (rust-lang/cargo#10693)
* fix bugs with `workspace` key and `update_toml` (rust-lang/cargo#10685)
* Bump to 0.64.0, update changelog (rust-lang/cargo#10687)
* List C compiler as a build dependency in README (rust-lang/cargo#10678)
* Add unstable `rustc-check-cfg` build script output (rust-lang/cargo#10539)

r? `@ehuss`
@ehuss ehuss added this to the 1.63.0 milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants